Prefer atomic_inc to atomic_increment #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Per kokkos/kokkos#7449 (comment) atomic_increment might get deprecated in favor of atomic_inc
Oh, sorry, I misunderstood, and thought it was the other way around. |
aprokop
force-pushed
the
atomic_increment
branch
from
c6f5243
to
7a78f6b
Compare
aprokop
changed the title
aprokop
changed the title
dalg24
reviewed
Oct 15, 2024
Comment on lines
37
to
39
| Kokkos::atomic_inc(&_counts(i)); | ||
|
|
||
| if (_counts(i) < _n) |
There was a problem hiding this comment.
This looks super sketchy
Suggested change
| Kokkos::atomic_inc(&_counts(i)); | |
| if (_counts(i) < _n) | |
| auto const counts_i = Kokkos::atomic_inc_fetch(&_counts(i)); | |
| if (counts_i < _n) |
There was a problem hiding this comment.
It's not really sketchy, but you are right, it is could be suboptimal in the case of threads sharing a query (which they currently don't when running BVH). I'll fix it.
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
aprokop
force-pushed
the
atomic_increment
branch
from
281c732
to
e9286b0
Compare
dalg24
reviewed
Oct 15, 2024
dalg24
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.