Introduce ARBORX_VERSION #1190
Merged
Introduce ARBORX_VERSION #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprokop
commented
Nov 13, 2024
| @@ -100,6 +100,7 @@ install(EXPORT ArborXTargets | |||
| DESTINATION ${CMAKE_INSTALL_DATADIR}/cmake/ArborX | |||
| ) | |||
|
|
|||
| set(ARBORX_VERSION "10799") | |||
There was a problem hiding this comment.
I chose the simplest version. I understand that there's an opportunity to desync with ARBORX_VERSION_STRING, but I think it would be an overkill to introduce something heavier.
There was a problem hiding this comment.
I am not sure I agree that it is fine to depart form the version we print.
I would get rid of the string version.
Also we should clarify with a comment how the version number is encoded.
There was a problem hiding this comment.
I would get rid of the string version.
That sounds reasonable to me.
Also we should clarify with a comment how the version number is encoded.
Will do.
Rombur
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized we didn't have an easy way for users to enable/disable code based on ArborX version.