Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using Kokkos::Experimental::sort_by_key #1191

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Nov 20, 2024

No description provided.

policy, zipped_begin, zipped_begin + n,
[](auto lhs, auto rhs) { return std::get<0>(lhs) < std::get<0>(rhs); });
#endif
using Kokkos::Experimental::sort_by_key;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good reason to keep the alias?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This way, we contain the changes in this PR to a single file. Otherwise, we would have to do the changes all over twice: in this PR, and once sort_by_key moves out of Experimental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants