Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of LegacyDefaultCallback #1193

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Get rid of LegacyDefaultCallback #1193

merged 2 commits into from
Nov 23, 2024

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Nov 23, 2024 •
edited
Loading

  • LegacyDefaultCallback is not used internally, so remove it from Details
  • Wrap DefaultCallback in the tests
  • Update couple examples to work with real values instead of hiding it

@aprokop aprokop added refactoring Code reorganization examples Anything to do with examples labels Nov 23, 2024
@aprokop aprokop merged commit c4653c5 into arborx:master Nov 23, 2024
1 of 2 checks passed
@aprokop aprokop deleted the move_legacy_default_callback branch November 23, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
examples Anything to do with examples refactoring Code reorganization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aprokop