-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use oneapi::dpl::sort_by_key if possible #928
Conversation
#if ONEDPL_VERSION_MAJOR > 2022 || \ | ||
(ONEDPL_VERSION_MAJOR == 2022 && ONEDPL_VESION_MINOR >= 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just require this? What's the minimum version for Kokkos? Do we care?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kokkos
doesn't have a minimum version; as of now, we are only using dpl::sort
anyway.
oneDPL
is not necessarily recent enough on the testbeds so I wouldn't want to require 2022.2 at this point.
@masterleinad please confirm that you verified that the code executes the sort by key with the new onedpl. In other words, that the macro check is correct. |
I tested without the macro guards before on the testbeds (with newer than default compiler versions, i.e., an |
I also tested manually with the 2022.2.0 oneDPL release which works fine. However, we get a bunch more warnings and it's not clear to me if it's beneficial to update the CI (here or in a follow-up pull request). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #926. I didn't see much of a difference in performance but that also wasn't really expected at this point.