Get rid of hardcoded float in the geometry algorithms #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also replace std::sqrt by Kokkos::sqrt to allow for half_t and bhalf_t calculations in the future.
dalg24
reviewed
Sep 8, 2023
| { | ||
| constexpr int DIM = GeometryTraits::dimension_v<Point1>; | ||
| float distance_squared = 0.0; | ||
| using Coordinate = typename GeometryTraits::coordinate_type<Point1>::type; | ||
| Coordinate distance_squared = 0; |
There was a problem hiding this comment.
Presumably if you want to use that coordinate type for the calculation you should cast b[d] and a[d] below.
We don't seem to enforce that the two points types are the same. Just using the coordinate type of the first point does not feel right.
There was a problem hiding this comment.
Guess we can use the type of a[d] - b[d] to allow implicit conversions.
masterleinad
approved these changes
Sep 11, 2023
dalg24
approved these changes
Sep 11, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also replace std::sqrt by Kokkos::sqrt to allow for half_t and bhalf_t calculations in the future.