Add copyright checking #957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprokop
force-pushed
the
check-copyright
branch
4 times, most recently
from
875e7ba
to
fa00114
Compare
aprokop
force-pushed
the
check-copyright
branch
2 times, most recently
from
3af488d
to
b0aa577
Compare
aprokop
force-pushed
the
check-copyright
branch
from
b0aa577
to
4b50b39
Compare
dalg24
reviewed
Oct 26, 2023
aprokop
force-pushed
the
check-copyright
branch
from
4b50b39
to
d898470
Compare
|
If we ever want to improve the script, we could look at git-clang-format. Seems like an overkill right now. |
|
Closing for now. Will make it part of the ArborX 2.0 when we go through the copyright again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
scripts/check_copyright.shscript to check whether the files in the PR have correct license. Correct license here means that it can only differ from the standard license form in one way: it could have 'XXXX-YYYY' year range, and the license file would only have 'YYYY'.Caveats:
origin/masterthat could be outdated, ororigincould be named differently)origin/master)I've also run the script to find all license discrepancies in the files that were modified this year (since 8d6dedb), and fixed them.