Use Kokkos::printf for Kokkos >= 4.2.00 #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprokop
reviewed
Oct 12, 2023
It is tricky. If it was in our internals I would say yes absolutely. But these are mostly examples and we would not want our users to use anything from |
Good point, I haven't checked where it's done. |
dalg24
requested changes
Oct 12, 2023
dalg24
reviewed
Oct 13, 2023
masterleinad
force-pushed
the
use_kokkos_printf
branch
from
332d22b
to
b64a608
Compare
dalg24
approved these changes
Oct 13, 2023
aprokop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header file (
impl/Kokkos_Printf.hpp) is not public so we are relying onKokkos_Core.hppfor now.Maybe, we can promote the header before the release, see kokkos/kokkos#6506.