Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix raw identifiers expanding as-is in ParseAttrs #1

Merged
merged 7 commits into from
Aug 13, 2021
Merged

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Aug 13, 2021

Synopsis

For now raw idents expand as-is. Because of that we have to write something like #[r#type = "something"] instead of more pleasant #[type = "something"]

Solution

Unraw ident before expanding ParseAttrs

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added the enhancement New feature or request label Aug 13, 2021
@ilslv ilslv self-assigned this Aug 13, 2021
@ilslv ilslv requested a review from tyranron August 13, 2021 10:56
@ilslv ilslv changed the title Fix raw identifiers expanding as-is in ParseAttrs Draft: Fix raw identifiers expanding as-is in ParseAttrs Aug 13, 2021
@tyranron tyranron changed the title Draft: Fix raw identifiers expanding as-is in ParseAttrs Fix raw identifiers expanding as-is in ParseAttrs Aug 13, 2021
@tyranron tyranron marked this pull request as ready for review August 13, 2021 13:42
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilslv thanks! 🍻

@tyranron tyranron merged commit 4179cab into master Aug 13, 2021
@tyranron tyranron deleted the fix-raw-idents branch August 13, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants