Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tile sort order to bulk data manager #11638

Merged
merged 12 commits into from
Nov 25, 2024

Conversation

chiatt
Copy link
Member

@chiatt chiatt commented Nov 19, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Add support for tile sortorder in bulk data manager

Issues Solved

Closes #11408

Checklist

  • I targeted one of these branches:
    • dev/8.0.x (under development): features, bugfixes not covered below
    • dev/7.6.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

@chiatt chiatt changed the title Cnh/add sortorder to bdm Add tile sort order to bulk data manager Nov 19, 2024
Copy link
Member

@johnatawnclementawn johnatawnclementawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 - added a small change to the tile excel tests just to check that sortorder in the import exhibit is being respected on import.

@johnatawnclementawn johnatawnclementawn merged commit f3390ef into dev/8.0.x Nov 25, 2024
7 checks passed
@johnatawnclementawn johnatawnclementawn deleted the cnh/add_sortorder_to_bdm branch November 25, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capture tile sort order during bulk import
2 participants