Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin glob to version that's compatible with Node.js <14.18 #185

Closed
wants to merge 2 commits into from

Conversation

Skn0tt
Copy link

@Skn0tt Skn0tt commented May 28, 2024

Hi there! Big fan of archiver. We've tracked down a small bug around compatibility with Node.js v14, specifically on versions before 14.18.

In isaacs/node-glob@435d1f7, the dependency glob started using node:-prefixed imports, which is only supported starting from Node 14.18. When using archiver on prior versions, it throws

Error: Cannot find module 'node:url'
Require stack:
- .../node_modules/archiver-utils/node_modules/glob/dist/commonjs/glob.js

Since archiver intends to support all of Node v14, the fix is to pin glob to the last version without that change. That's what this PR does.

An alternative solution would be to drop support for v14 altogether, but personally i'd prefer keeping some compatibility.

@ctalkington ctalkington self-requested a review June 4, 2024 15:23
@Skn0tt Skn0tt closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant