Merge pull request #484 from pennam/unor4-warnings

UNO R4 WiFi fix warnings
arduino-libraries · Jul 22, 2024 · 91db7a3 · 91db7a3
2 parents 4c0d20e + 605e16b
commit 91db7a3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/src/ota/OTA.h b/src/ota/OTA.h
@@ -50,8 +50,7 @@ using ArduinoCloudOTA = ESP32OTACloudProcess;
 #include "implementation/OTAUnoR4.h"
 using ArduinoCloudOTA = UNOR4OTACloudProcess;
 
-// TODO Check if a macro already exist
-constexpr uint32_t OtaMagicNumber = 0x234110020; // TODO check this value is correct
+constexpr uint32_t OtaMagicNumber = 0x23411002;
 
 #else
 #error "This Board doesn't support OTA"

diff --git a/src/tls/utility/TLSClientMqtt.cpp b/src/tls/utility/TLSClientMqtt.cpp
@@ -58,6 +58,7 @@ void TLSClientMqtt::begin(ConnectionHandler & connection) {
    * also present in older firmware revisions
    * https://github.com/arduino/uno-r4-wifi-usb-bridge/blob/f09ca94fdcab845b8368d4435fdac9f6999d21d2/certificates/certificates.pem#L852
    */
+  (void)connection;
 #elif defined(ARDUINO_ARCH_ESP32)
   setCACertBundle(x509_crt_bundle);
 #elif defined(ARDUINO_ARCH_ESP8266)

diff --git a/src/tls/utility/TLSClientOta.cpp b/src/tls/utility/TLSClientOta.cpp
@@ -54,6 +54,7 @@ void TLSClientOta::begin(ConnectionHandler &connection) {
   /* AWS Root CAs are configured in uno-r4-wifi-usb-bridge/libraries/Arduino_ESP32_OTA
    * https://github.com/arduino-libraries/Arduino_ESP32_OTA/blob/fc755e7d1d3946232107e2590662ee08d6ccdec4/src/tls/amazon_root_ca.h
    */
+  (void)connection;
 #elif defined(ARDUINO_ARCH_ESP32)
   setCACertBundle(x509_crt_bundle);
 #elif defined(ARDUINO_ARCH_ESP8266)