STM32H7 OTA code cleanup #477

pennam · 2024-06-04T09:31:10Z

Apply after #478

codecov · 2024-06-04T09:49:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.26%. Comparing base (b93768d) to head (8143741).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #477   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files          32       32           
  Lines        1478     1478           
=======================================
  Hits         1408     1408           
  Misses         70       70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/ota/implementation/OTASTM32H7.cpp

github-actions · 2024-06-10T08:30:54Z

Memory usage change @ 1ac0098

Board	flash	%	RAM for global variables	%
`arduino:esp32:nano_nora`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_edge:edge_control`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_giga:giga`	🔺 0 - +176	0.0 - +0.01	💚 -32 - 0	-0.01 - 0.0
`arduino:mbed_nano:nanorp2040connect`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_nicla:nicla_vision`	🔺 0 - +176	0.0 - +0.01	💚 -32 - 0	-0.01 - 0.0
`arduino:mbed_opta:opta`	🔺 0 - +176	0.0 - +0.01	💚 -32 - 0	-0.01 - 0.0
`arduino:renesas_uno:unor4wifi`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkr1000`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrgsm1400`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrnb1500`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwan1300`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwifi1010`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:nano_33_iot`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`esp32:esp32:esp32`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`esp8266:esp8266:huzzah`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/ArduinoIoTCloud-Advanced` flash	%	`examples/ArduinoIoTCloud-Advanced` RAM for global variables	%	`examples/ArduinoIoTCloud-Basic` flash	%	`examples/ArduinoIoTCloud-Callbacks` flash	%	`examples/ArduinoIoTCloud-Callbacks` RAM for global variables	%	`examples/ArduinoIoTCloud-Schedule` flash	%	`examples/utility/ArduinoIoTCloud_Travis_CI` flash	%	`examples/ArduinoIoTCloud-DeferredOTA` flash	%	`examples/ArduinoIoTCloud-DeferredOTA` RAM for global variables	%	`examples/utility/Provisioning` flash	%	`examples/utility/Provisioning` RAM for global variables	%	`examples/utility/SelfProvisioning` flash	%	`examples/utility/SelfProvisioning` RAM for global variables	%
`arduino:esp32:nano_nora`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_edge:edge_control`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_giga:giga`	104	0.01	0	0.0	104	0.01	168	0.01	0	0.0	176	0.01	176	0.01	104	0.01	-32	-0.01	0	0.0	0	0.0
`arduino:mbed_nano:nanorp2040connect`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_nicla:nicla_vision`	104	0.01	-32	-0.01	176	0.01	168	0.01	-32	-0.01	112	0.01	176	0.01	104	0.01	0	0.0	0	0.0	0	0.0
`arduino:mbed_opta:opta`	112	0.01	-32	-0.01	168	0.01	176	0.01	-32	-0.01	104	0.01	168	0.01	112	0.01	0	0.0	0	0.0	0	0.0
`arduino:renesas_uno:unor4wifi`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkr1000`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0					0	0.0	0	0.0
`arduino:samd:mkrgsm1400`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0					0	0.0	0	0.0
`arduino:samd:mkrnb1500`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0					0	0.0	0	0.0
`arduino:samd:mkrwan1300`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwifi1010`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:nano_33_iot`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`esp32:esp32:esp32`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`esp8266:esp8266:huzzah`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/ArduinoIoTCloud-Callbacks<br>flash,%,examples/ArduinoIoTCloud-Callbacks<br>RAM for global variables,%,examples/ArduinoIoTCloud-Schedule<br>flash,%,examples/ArduinoIoTCloud-Schedule<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/ArduinoIoTCloud-DeferredOTA<br>flash,%,examples/ArduinoIoTCloud-DeferredOTA<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:esp32:nano_nora,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_edge:edge_control,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_giga:giga,104,0.01,0,0.0,104,0.01,0,0.0,168,0.01,0,0.0,176,0.01,0,0.0,176,0.01,0,0.0,104,0.01,-32,-0.01,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,104,0.01,-32,-0.01,176,0.01,0,0.0,168,0.01,-32,-0.01,112,0.01,0,0.0,176,0.01,0,0.0,104,0.01,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_opta:opta,112,0.01,-32,-0.01,168,0.01,0,0.0,176,0.01,-32,-0.01,104,0.01,0,0.0,168,0.01,0,0.0,112,0.01,0,0.0,0,0.0,0,0.0,,,,
arduino:renesas_uno:unor4wifi,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,,,,,
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,,,,,
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,,,,,

Co-authored-by: Andrea Gilardoni <4046444+andreagilardoni@users.noreply.github.com>

per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 4, 2024

arduino-libraries deleted a comment from github-actions bot Jun 4, 2024

pennam force-pushed the stm32h7-ota branch from 0ccd8a8 to 45f487b Compare June 4, 2024 12:45

pennam changed the title ~~Stm32h7 ota~~ STM32H7 OTA code cleanup Jun 5, 2024

pennam requested a review from andreagilardoni June 5, 2024 07:08

andreagilardoni requested changes Jun 7, 2024

View reviewed changes

src/ota/implementation/OTASTM32H7.cpp Show resolved Hide resolved

pennam and others added 13 commits June 10, 2024 10:47

OTA: STM32H7 remove watchdog kik

a869130

OTA: STM32H7 remove unused variables

e5eca05

OTA: STM32H7 remove commented code

44b5dc3

OTA: STM32H7 storage type is always QSPI_FLASH_FATFS_MBR

5956436

OTA: STM32H7 rename portenta namespace in STM32H747OTA

603acd5

OTA: STM32H7 remove storage variable

4888d27

OTA: STM32H7 Add storage type constexpr

9f1117a

OTA: STM32H7 add partition constexpr

af07e71

OTA: STM32H7 add OTA magic number constexpr

6694980

OTA: STM32H7 merge storageOpen and findProgramLength

7671c39

OTA: STM32H7 use constants for filename and path

340ab06

OTA: STM32H7 remove _private_length private variable

4edf9b4

OTA: STM32H7 add check on fopen failures

8143741

Co-authored-by: Andrea Gilardoni <4046444+andreagilardoni@users.noreply.github.com>

pennam force-pushed the stm32h7-ota branch 2 times, most recently from 53505e6 to 8143741 Compare June 10, 2024 08:48

pennam requested a review from andreagilardoni June 10, 2024 09:14

arduino-libraries deleted a comment from github-actions bot Jun 10, 2024

andreagilardoni approved these changes Jun 10, 2024

View reviewed changes

pennam merged commit c6b3c77 into arduino-libraries:master Jun 10, 2024
23 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

STM32H7 OTA code cleanup #477

STM32H7 OTA code cleanup #477

pennam commented Jun 4, 2024 •

edited

Loading

codecov bot commented Jun 4, 2024 •

edited

Loading

github-actions bot commented Jun 10, 2024

STM32H7 OTA code cleanup #477

STM32H7 OTA code cleanup #477

Conversation

pennam commented Jun 4, 2024 • edited Loading

codecov bot commented Jun 4, 2024 • edited Loading

Codecov Report

github-actions bot commented Jun 10, 2024

pennam commented Jun 4, 2024 •

edited

Loading

codecov bot commented Jun 4, 2024 •

edited

Loading