Fix ota download byte count #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #514 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 33 33
Lines 1520 1520
=======================================
Hits 1450 1450
Misses 70 70 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Memory usage change @ 84cda53
Click for full report table
Click for full report CSV |
per1234
added
type: imperfection
| /* Avoid tight loop and allow yield */ | ||
| delay(1); | ||
| continue; | ||
| } | ||
|
|
||
| http_res = http_client->read(context->buffer, context->buf_len); | ||
| http_res = http_client->read(context->buffer, (available > context->buf_len) ? context->buf_len : available); |
There was a problem hiding this comment.
HttpClient::read(buf, len) reads at most len bytes, I think that this is superfluous, since it is already being performed under the hood.
| @@ -159,7 +160,7 @@ void OTADefaultCloudProcessInterface::parseOta(uint8_t* buffer, size_t buf_len) | |||
| for(uint8_t* cursor=(uint8_t*)buffer; cursor<buffer+buf_len; ) { | |||
| switch(context->downloadState) { | |||
| case OtaDownloadHeader: { | |||
| uint32_t copied = buf_len < sizeof(context->header.buf) ? buf_len : sizeof(context->header.buf); | |||
| const uint32_t copied = context->headerCopiedBytes + buf_len < sizeof(context->header.buf) ? buf_len : sizeof(context->header.buf) - context->headerCopiedBytes; | |||
There was a problem hiding this comment.
I think it is far more readable this way. It is exactly the same.
Suggested change
| const uint32_t copied = context->headerCopiedBytes + buf_len < sizeof(context->header.buf) ? buf_len : sizeof(context->header.buf) - context->headerCopiedBytes; | |
| const uint32_t copied = buf_len < sizeof(context->header.buf) - context->headerCopiedBytes ? buf_len : sizeof(context->header.buf) - context->headerCopiedBytes; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.