Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to restart OTA multiple times #21

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

pennam
Copy link
Collaborator

@pennam pennam commented Oct 16, 2023

Add the possibility to restart OTA multiple times on error or success keeping the same global object:

  • Initialize variables inside begin()
  • Ensure _client is always deleted returning from download function

@pennam pennam mentioned this pull request Oct 19, 2023
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Oct 19, 2023
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Oct 19, 2023
@pennam pennam changed the title Add the possibility to restart OTA multiple times [WIRE-120] Add the possibility to restart OTA multiple times Oct 19, 2023
@pennam pennam changed the title [WIRE-120] Add the possibility to restart OTA multiple times Add the possibility to restart OTA multiple times Oct 19, 2023
@pennam pennam force-pushed the restartable branch 2 times, most recently from 82bfb2a to c644a2f Compare November 22, 2023 09:16
@pennam
Copy link
Collaborator Author

pennam commented Nov 22, 2023

rebased on master to resolve conflicts

Copy link

Memory usage change @ c644a2f

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 0 - +220 0.0 - +0.01 0 - 0 0.0 - 0.0
esp32:esp32:esp32 🔺 0 - +224 0.0 - +0.02 0 - 0 0.0 - 0.0
Click for full report table
Board examples/OTA_Arduino_Server
flash
% examples/OTA_Arduino_Server
RAM for global variables
% examples/OTA_GitHub_Server
flash
% examples/OTA_GitHub_Server
RAM for global variables
% examples/NANO_ESP32_Blink
flash
% examples/NANO_ESP32_Blink
RAM for global variables
% examples/LOLIN_32_Blink
flash
% examples/LOLIN_32_Blink
RAM for global variables
%
arduino:esp32:nano_nora 220 0.01 0 0.0 220 0.01 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 224 0.02 0 0.0 224 0.02 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/OTA_Arduino_Server<br>flash,%,examples/OTA_Arduino_Server<br>RAM for global variables,%,examples/OTA_GitHub_Server<br>flash,%,examples/OTA_GitHub_Server<br>RAM for global variables,%,examples/NANO_ESP32_Blink<br>flash,%,examples/NANO_ESP32_Blink<br>RAM for global variables,%,examples/LOLIN_32_Blink<br>flash,%,examples/LOLIN_32_Blink<br>RAM for global variables,%
arduino:esp32:nano_nora,220,0.01,0,0.0,220,0.01,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,224,0.02,0,0.0,224,0.02,0,0.0,,,,,0,0.0,0,0.0

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Nov 22, 2023
@pennam pennam merged commit 8d6958e into arduino-libraries:main Nov 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant