Update NTPClient.h #208
Open
Update NTPClient.h #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add getDate(), getMonth(), getYear(), getFullFormattedTime(), and getTM_t()
|
|
|
Memory usage change @ cf242bb
Click for full report table
Click for full report CSV |
per1234
added
type: enhancement
This was
linked to
issues
Jun 23, 2024
per1234
previously requested changes
Jun 23, 2024
There was a problem hiding this comment.
Hi @drovosekov. Thanks for taking the time to submit a pull request.
The pull request must contain your complete proposal, but the proposed changes to NTPClient.cpp are missing from this pull request. I see you submitted them in a separate pull request (#209), but that is not allowed.
Please add the proposed NTPClient.cpp to this pull request. You can do that by editing the file in the patch-2 branch of your fork and then committing the change to that branch. Any commits you push to the patch-2 will automatically be added to this pull request.
Closed
|
Memory usage change @ 017a61b
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add getDate(), getMonth(), getYear(), getFullFormattedTime(), and getTM_t()