Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BoardIdentify gRPC call. #2794

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Dec 23, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Adds the BoardIdentify gRPC call, this function performs the board identification based on the given "upload port properties".

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie added type: enhancement Proposed improvement topic: gRPC Related to the gRPC interface labels Dec 23, 2024
@cmaglie cmaglie self-assigned this Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 67.27273% with 54 lines in your changes missing coverage. Please review.

Project coverage is 67.66%. Comparing base (7782c89) to head (1432af1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
commands/service_board_identify.go 67.40% 31 Missing and 13 partials ⚠️
commands/service_board_list.go 66.66% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2794      +/-   ##
==========================================
+ Coverage   67.59%   67.66%   +0.06%     
==========================================
  Files         238      239       +1     
  Lines       22374    22378       +4     
==========================================
+ Hits        15123    15141      +18     
+ Misses       6062     6045      -17     
- Partials     1189     1192       +3     
Flag Coverage Δ
unit 67.66% <67.27%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie force-pushed the board-identify-grpc branch from 273e6a5 to 1432af1 Compare December 24, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant