n64: step rsp dma during rsp execution #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of advancing RSP DMA only after each CPU basic block, allow it to run between each RSP block. This prevents the RSP from racing with the DMAs it initiates in the event of a long running CPU block (which can trigger multiple consecutive blocks of RSP execution). This fixes hangs in Tarzan and possibly other games that use MusyX. Another observable side effect of this change is that when the RSP is halted, it no longer risks falling increasingly behind the CPU, because ares will now step multiple times if needed instead of just once.
rasky
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of advancing RSP DMA only after each CPU basic block, allow it to run between each RSP block. This prevents the RSP from racing with the DMAs it initiates in the event of a long running CPU block (which can trigger multiple consecutive blocks of RSP execution).
This fixes hangs in Tarzan and possibly other games that use MusyX.
Another observable side effect of this change is that when the RSP is halted, it no longer risks falling increasingly behind the CPU, because ares will now step multiple times if needed instead of just once.