Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New and improved scripts #71

Merged
merged 29 commits into from
Jan 31, 2024
Merged

New and improved scripts #71

merged 29 commits into from
Jan 31, 2024

Conversation

ipitio
Copy link
Collaborator

@ipitio ipitio commented Jan 22, 2024 •
edited
Loading

This PR features new logic for scheduling tests and a few improvements, enabling arevindh/AdminLTE#84

Features:

  • webpage: Logic to handle setting a schedule for an arbitrary number of (fractional) hours
  • speedtest: Failover to speedtest-cli when speedtest fails
  • mod: see New and improved functions pihole-speedtest#153
  • mod & speedtest: New unified location

Fixes:

  • Logging db operations
  • Syntax and grammar

Enhancements:

  • Allow service to be (re)set without args
  • Allow setting all days
  • Local/offline mod script

@ipitio ipitio changed the title Grammar Always set service and fix grammar Jan 25, 2024
@ipitio ipitio mentioned this pull request Jan 25, 2024
Merged
@ipitio ipitio mentioned this pull request Jan 25, 2024
Merged
@ipitio ipitio changed the title Always set service and fix grammar New and improved scheduling functionality Jan 25, 2024
@ipitio ipitio changed the title New and improved scheduling functionality New and improved scheduling Jan 27, 2024
@ipitio ipitio changed the title New and improved scheduling New and improved scripts Jan 31, 2024
@arevindh arevindh merged commit 1721638 into arevindh:master Jan 31, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ipitio @arevindh