Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category section UI modified #1246

Closed
wants to merge 2 commits into from
Closed

Category section UI modified #1246

wants to merge 2 commits into from

Conversation

sau-mili
Copy link
Contributor

Related Issue

[Cite any related issue(s) this pull request addresses. If none, simply state "None”]

resolves #1223

Description

[Please include a brief description of the changes or features added]

  • Bug fixed: Spacing between components, and font issue
  • Change the category icon images
  • Added missing categories
  • Fixed font size, alignment, weight
  • Improved the category with grid css
  • Made the category almost similar to that of original website

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

BEFORE

Screenshot 2024-06-15 192700

AFTER

Screenshot 2024-06-15 192653

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jun 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flipkart-clone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 0:05am

@sau-mili
Copy link
Contributor Author

@arghadipmanna101 can you check now?

@arghadipmanna101
Copy link
Owner

Issue :

image

@sau-mili
Copy link
Contributor Author

can you check now?
Screenshot 2024-06-18 235815

@sau-mili
Copy link
Contributor Author

@arghadipmanna101 please check

@sau-mili
Copy link
Contributor Author

@arghadipmanna101 i have resolved conflicts please check

@sau-mili
Copy link
Contributor Author

@arghadipmanna101 check my PR please. And please check it before changing the categorydata.json file. It was originally wrongly aligned, I fixed it twice, but subsequent merges is causing unresolvable conflicts and repitition

@arghadipmanna101
Copy link
Owner

error :
image

@sau-mili
Copy link
Contributor Author

sau-mili commented Jul 9, 2024

This can’t be due to my PR only. i haven’t changed any other part of the code. Can you check the previous merges please?

@arghadipmanna101
Copy link
Owner

This can’t be due to my PR only. i haven’t changed any other part of the code. Can you check the previous merges please?

Ok once do git pull and then recreate a new pr .

@sau-mili
Copy link
Contributor Author

sau-mili commented Jul 9, 2024

If I pull the changes, then these bugs will add up to my edits too.. Can you please tell me once this is figured out? Since, the json file editing required a lot of changes, and took me really long time to fix thrice before since, PRs that were done after My PR was merged before this.

@arghadipmanna101
Copy link
Owner

If I pull the changes, then these bugs will add up to my edits too.. Can you please tell me once this is figured out? Since, the json file editing required a lot of changes, and took me really long time to fix thrice before since, PRs that were done after My PR was merged before this.

https://flipkart-clone-seven-azure.vercel.app/
This is my present website, you can check there have no error.

@sau-mili
Copy link
Contributor Author

sau-mili commented Jul 9, 2024

i am doing a new pull

@sau-mili sau-mili closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Change category images with oroginal FP Page images
2 participants