Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Search Button and Countdown Timer for Offers.html page #1388

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

coderiksenthil
Copy link
Contributor

Related Issue

#1357

Description

The offer.html page should include a search button to help users quickly find specific offers and a countdown timer to indicate how long each offer will remain available. The search functionality will allow users to filter offers based on keywords, while the countdown timer will display the remaining time for each offer to create a sense of urgency.

For the search button, I’d like a search function that filters offers in real-time based on user input, updating the page with matching results. For the countdown timer, I’d like it to dynamically count down days, hours, minutes, and seconds until each offer expires, ensuring users are aware of how much time is left to take advantage of the deals.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Before (without a search bar and countdown)
image
After (with a search bar and countdown)
image

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]
As alternatives, implementing a dropdown filter or sorting options would not effectively provide the same real-time search experience as the search button. Regarding the countdown timer, static expiration dates or manually updated statuses do not offer real-time updates, which are crucial for maintaining user engagement and urgency.

Copy link

vercel bot commented Jul 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flipkart-clone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 11:05am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @coderiksenthil! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. kindly remember to check our contributing guidelines

@coderiksenthil
Copy link
Contributor Author

coderiksenthil commented Jul 20, 2024

@arghadipmanna101 Can you merge my PR when free, it has been a week

@arghadipmanna101
Copy link
Owner

work on updated website

@coderiksenthil
Copy link
Contributor Author

sure

@coderiksenthil
Copy link
Contributor Author

There are no conflict, Please merge my PR when free

@arghadipmanna101 arghadipmanna101 merged commit 5c18bb2 into arghadipmanna101:main Jul 30, 2024
1 check passed
@arghadipmanna101 arghadipmanna101 added level3 An Hard issue gssoc Fun with GSSOC'24 labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Fun with GSSOC'24 level3 An Hard issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants