Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Description Page Improved #1396

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Product Description Page Improved #1396

merged 1 commit into from
Jul 15, 2024

Conversation

sau-mili
Copy link
Contributor

@sau-mili sau-mili commented Jul 13, 2024

Related Issue

[Cite any related issue(s) this pull request addresses. If none, simply state "None”]
closes #1225

Description

[Please include a brief description of the changes or features added]

  • Fixed font sizes
  • Added icons in front of bank offers
  • T&C , "View more", "View X more"
  • Added question mark(info) icons where necessary
  • Added Check delivery by pincode section
  • Added warranty section
  • Button colours, height, width fixed
  • alignments fixed
  • Overall Page's Frontend/UI improved

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

BEFORE

image

AFTER

image

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jul 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flipkart-clone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2024 5:48pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @sau-mili! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. kindly remember to check our contributing guidelines

@arghadipmanna101 arghadipmanna101 merged commit 8832bd6 into arghadipmanna101:main Jul 15, 2024
2 of 3 checks passed
@arghadipmanna101 arghadipmanna101 added level2 An midium issue. gssoc Fun with GSSOC'24 labels Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Fun with GSSOC'24 level2 An midium issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Improve product page
2 participants