Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kube-Burner to Tools Directory for ArgoCD Benchmarking #4

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Mangaal
Copy link

@Mangaal Mangaal commented Aug 22, 2024

Description:
This PR introduces Kube-Burner into the tools directory of the argo-cd-benchmarking repository. It includes:

  • Kube-Burner Configuration: Added configuration files for Kube-Burner, including setup for ArgoCD performance testing.

  • Sample Test Resource: Included a sample resource to demonstrate how to use Kube-Burner for performance benchmarking.

  • Kube-Burner Templates: Added YAML templates for ArgoCD applications to be used with Kube-Burner.

  • Metric Endpoint and Profiling Configuration: Provided a sample configuration for setting up metric endpoints and profiling within Kube-Burner.

Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
spec:
project: default
source:
repoURL: https://github.com/Mangaal/argocd-performance-test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be updated to the argoproj-labs repo eventually?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I need to update this

@@ -0,0 +1,167 @@
# ArgoCD Performance Testing with Kube-Burner
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a short entry in the main README.md with a link to this new folder?, following the example that is already there

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the kube-burer as a second tools

Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Copy link
Collaborator

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review during sig-scalability testing:
Tool’s measurements would not be accurate, kube-burner would need to be extended to understand ArgoCD states

Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
@Mangaal
Copy link
Author

Mangaal commented Oct 3, 2024

I have enhanced Kube-Burner to support direct status checks for ArgoCD applications. The configuration has been updated to allow monitoring of specific application states, such as "Synced," using a custom status path. This ensures accurate tracking of ArgoCD application health and enables more precise performance testing and metric collection.

Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants