Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Kuttl tests to Ginkgo and enable GH E2E/unit test workflow #19

Merged
merged 5 commits into from
Jan 20, 2024
Merged

Port Kuttl tests to Ginkgo and enable GH E2E/unit test workflow #19

merged 5 commits into from
Jan 20, 2024

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Jan 19, 2024 •
edited
Loading

This PR:

  • Ports the existing Kuttl tests to Ginkgo, and removes the Kuttl tests
  • Updates Makefile to call the new Ginkgo-based E2E tests
  • Updated GitHub workflow to enable E2E/Unit tests to be run against every PR
  • Misc tweaks
    • Convert Phase to a constant
    • Fix import warnings

Fixes #9

@jgwest
Port Kuttl tests to Ginkgo and enable GH E2E/unit test workflow
5051a0f 
Signed-off-by: Jonathan West <jonwest@redhat.com>
@jgwest
Fix GitHub Workflow YAML formatting
9b94374 
Signed-off-by: Jonathan West <jonwest@redhat.com>
@jgwest
Fix E2E workflow error
92229fc 
Signed-off-by: Jonathan West <jonwest@redhat.com>
@jgwest
Fix another E2E workflow error
0e4ea61 
Signed-off-by: Jonathan West <jonwest@redhat.com>
@jgwest
Update package references
4ac98cc 
Signed-off-by: Jonathan West <jonwest@redhat.com>
@jgwest jgwest merged commit 1cb577b into argoproj-labs:main Jan 20, 2024
4 checks passed
@jgwest jgwest mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Basic CI needs to be extended
1 participant
@jgwest