Run the E2E tests that work for both cluster-scoped and namespace-scope modes, on both #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan West <jonwest@redhat.com>
jgwest
force-pushed
the
switch-to-cluster-scoped-test-default-may-2024
branch
from
53dc87c
to
fe739ab
Compare
jgwest
changed the title
jgwest
commented
Jun 13, 2024
| @@ -21,7 +21,7 @@ set -ex | |||
|
|
|||
| if [ "$NAMESPACE_SCOPED_ARGO_ROLLOUTS" == "true" ]; then | |||
|
|
|||
| go test -v -p=1 -timeout=30m -race -count=1 -coverprofile=coverage.out ./tests/e2e/. ./tests/e2e/namespace-scoped | |||
| go test -v -p=1 -timeout=30m -race -count=1 -coverprofile=coverage.out ./tests/e2e/namespace-scoped | |||
There was a problem hiding this comment.
I removed ./tests because that logic is now invoked directly from the namespace/cluster-scoped tests
|
LGTM |
|
Thanks @chetan-rns and @Rizwana777! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it:
tests/e2epackage, but by default we only run these during namespace-scoped testsHave you updated the necessary documentation?