Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to quay.io for E2E test image to avoid throttling #66

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Jun 12, 2024

What does this PR do / why we need it:

  • Some of our E2E tests use a docker.io-hosted image with a generic tag, which means we are subject to docker.io rate limiting (causing E2E tests to fail), and the contents of the image may change arbitrarily
  • I've mirrored the image to quay.io to avoid rate limiting on image pulls, and hardcoded the SHA in the test to ensure the content doesn't change
  • There's probably an even better place for it, or an alternative image, but for this PR the perfect is the enemy of the good

Signed-off-by: Jonathan West <jonwest@redhat.com>
@jgwest jgwest changed the title Switch to quay.to to avoid throttling Switch to quay.to for E2E test image to avoid throttling Jun 12, 2024
@jgwest jgwest changed the title Switch to quay.to for E2E test image to avoid throttling Switch to quay.io for E2E test image to avoid throttling Jun 12, 2024
Signed-off-by: Jonathan West <jonwest@redhat.com>
Copy link
Collaborator

@chetan-rns chetan-rns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

We should consider migrating to the official argoprojlabs repo https://quay.io/organization/argoprojlabs

@jgwest
Copy link
Member Author

jgwest commented Jun 14, 2024

Thanks @chetan-rns , I have opened #67 to track the migration.

@jgwest jgwest merged commit a33a37e into argoproj-labs:main Jun 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants