Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix '.spec.additionalMetadata' field issue where is is not updating labels/annotations of existing rollouts resources #76

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Fix '.spec.additionalMetadata' field issue where is is not updating labels/annotations of existing rollouts resources #76

merged 2 commits into from
Jul 31, 2024

Conversation

Rizwana777
Copy link
Collaborator

@Rizwana777 Rizwana777 commented Jul 23, 2024 •
edited by jgwest
Loading

@Rizwana777 Rizwana777 force-pushed the issue-4779 branch 6 times, most recently from 50d155d to 38ccc81 Compare July 24, 2024 19:11
jgwest
jgwest requested changes Jul 25, 2024
View reviewed changes
controllers/utils.go Show resolved Hide resolved
controllers/resources.go Outdated Show resolved Hide resolved
controllers/resources.go Outdated Show resolved Hide resolved
controllers/resources.go Outdated Show resolved Hide resolved
controllers/resources.go Outdated Show resolved Hide resolved
controllers/resources_test.go Outdated Show resolved Hide resolved
controllers/resources.go Outdated Show resolved Hide resolved
controllers/resources.go Outdated Show resolved Hide resolved
controllers/resources.go Outdated Show resolved Hide resolved
controllers/utils.go Outdated Show resolved Hide resolved
@Rizwana777 Rizwana777 force-pushed the issue-4779 branch 2 times, most recently from 10656c6 to 9ec5ab2 Compare July 29, 2024 10:10
@Rizwana777
Fix '.spec.additionalMetadata' field issue
5d00cdb 
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
@jgwest
Refactor service/monitor function, add back existing tests
6e57897 
Signed-off-by: Jonathan West <jonwest@redhat.com>
jgwest
jgwest approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Rizwana777!

@jgwest jgwest merged commit b8dae39 into argoproj-labs:main Jul 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgwest jgwest jgwest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Rizwana777 @jgwest