Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:update operator-sdk and kubebuilder version to match sibling gitops/argocd-operators #79

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

Rizwana777
Copy link
Collaborator

Fixes #77

@Rizwana777 Rizwana777 force-pushed the issue-5098 branch 3 times, most recently from 58c2833 to b77ada6 Compare July 30, 2024 11:48
@Rizwana777
Copy link
Collaborator Author

JIRA

Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
@jgwest
Copy link
Member

jgwest commented Aug 7, 2024

I pushed a commit to move the controller code back from internal/controller to controllers. Unfortunately it looks like gitops-operator needs to be able to call that code, and it's not possible to call an internal package from external gitops-operator.

Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Rizwana777!

@jgwest jgwest merged commit a96aa79 into argoproj-labs:main Aug 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants