Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Service NodePort conflicts when running on large cluster #80

Merged

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Jul 30, 2024

What does this PR do / why we need it:

  • When running the Rollouts operator E2E tests on OpenShift, I noticed that the E2E tests were failing due to other Services using the same NodePort ports that we were using in these tests.
  • This will only happen when running on a cluster that is running other services using NodePort, and not, for example, as part of GitHub actions E2E test run
  • As a solution, or at least a workaround, I have incremented the ports we used to avoid conflicts.

Have you updated the necessary documentation?

  • Documentation update is required by this PR, and has been updated.

Signed-off-by: Jonathan West <jonwest@redhat.com>
@jgwest jgwest force-pushed the avoid-service-node-port-conflict-july-2024 branch from 1a931a5 to 184bad9 Compare July 30, 2024 08:42
@jgwest jgwest requested a review from jparsai July 31, 2024 07:19
@jparsai
Copy link
Collaborator

jparsai commented Jul 31, 2024

/lgtm @jgwest

@jgwest
Copy link
Member Author

jgwest commented Jul 31, 2024

Thanks @jparsai!

@jgwest jgwest merged commit 8f5cde1 into argoproj-labs:main Jul 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants