Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-arch images to E2E tests #91

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Sep 16, 2024

What does this PR do / why we need it:

  • Switch to nginx-unprivileged image, since it has an multi-arch image available, and runs in restricted Namespace
  • Switch to multi-arch image for rollouts-demo image for upstream E2E tests (image is otherwise unmodified)
  • Add an additional expected error to list.

Have you updated the necessary documentation?

  • Documentation update is required by this PR, and has been updated.

Which issue(s) this PR fixes:
N/A

How to test changes / Special notes to the reviewer: N/A

Signed-off-by: Jonathan West <jonwest@redhat.com>
@jgwest jgwest force-pushed the add-support-for-multi-arch-images branch from 386612f to be3bb15 Compare September 16, 2024 22:57
@Rizwana777
Copy link
Collaborator

/lgtm

@jgwest jgwest merged commit 573c35a into argoproj-labs:main Sep 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants