Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add argo linting for examples #1163

Open
elliotgunton opened this issue Aug 20, 2024 · 1 comment
Open

Add argo linting for examples #1163

elliotgunton opened this issue Aug 20, 2024 · 1 comment
Assignees
@jeongukjae
Labels
type:task A general task

Comments

@elliotgunton
Copy link
Collaborator

Quite a few issues thrown up by new DAGs would have been surfaced by using an argo lint. We already have on-cluster tests so this shouldn't be too hard to add.
@elliotgunton elliotgunton added the type:task A general task label Aug 20, 2024
@elliotgunton elliotgunton mentioned this issue Oct 2, 2024
Merged
3 tasks
This was referenced Oct 17, 2024
Open
Merged
sambhav pushed a commit that referenced this issue Oct 21, 2024
@jeongukjae
Fix some argo lint errors in examples folder (#1244)
3266a5b 
**Pull Request Checklist**
- [ ] ~~Fixes~~ #1163 
- [ ] ~~Tests added~~
- [ ] ~~Documentation/examples added~~
- [x] [Good commit messages](https://cbea.ms/git-commit/) and/or PR
title

**Description of PR**

Fixed argo lint errors in following dirs:
- examples/workflows/use-case
- examples/workflows/scripts
- examples/workflows/misc

---------

Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
@jeongukjae
Copy link
Collaborator

@elliotgunton I can do this.
while adding argo lint, I will fix other lint errors as well.

@jeongukjae jeongukjae self-assigned this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeongukjae jeongukjae

Labels
type:task A general task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeongukjae @elliotgunton