Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some argo lint errors in examples folder #1244

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

jeongukjae
Copy link
Collaborator

@jeongukjae jeongukjae commented Oct 17, 2024

Pull Request Checklist

Description of PR

Fixed argo lint errors in following dirs:

  • examples/workflows/use-case
  • examples/workflows/scripts
  • examples/workflows/misc

Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
@jeongukjae jeongukjae self-assigned this Oct 17, 2024
@jeongukjae jeongukjae added semver:patch A change requiring a patch version bump type:task A general task labels Oct 17, 2024
@jeongukjae jeongukjae marked this pull request as ready for review October 17, 2024 13:02
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.9%. Comparing base (e7ed95b) to head (889f911).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1244   +/-   ##
=====================================
  Coverage   45.9%   45.9%           
=====================================
  Files         60      60           
  Lines       4082    4082           
  Branches     857     857           
=====================================
  Hits        1875    1875           
  Misses      2175    2175           
  Partials      32      32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sambhav sambhav merged commit 3266a5b into argoproj-labs:main Oct 21, 2024
25 checks passed
@jeongukjae jeongukjae deleted the fix-use-case-linte-error branch October 21, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants