Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine all code coverages in CI #1259

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

jeongukjae
Copy link
Collaborator

@jeongukjae jeongukjae commented Nov 5, 2024

Pull Request Checklist

Description of PR
Currently, the codecov reports definitely covered line in PR pages.
So in this pr, I tried to combine all code coverages in CI and report them to codecov server.

Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.2%. Comparing base (eadeb61) to head (f357ce1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1259      +/-   ##
========================================
+ Coverage   45.8%   86.2%   +40.3%     
========================================
  Files         60      60              
  Lines       4109    4109              
  Branches     659     659              
========================================
+ Hits        1885    3543    +1658     
+ Misses      2195     393    -1802     
- Partials      29     173     +144     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
@jeongukjae jeongukjae added the semver:patch A change requiring a patch version bump label Nov 5, 2024
@jeongukjae jeongukjae changed the title Update make test command Fix code coverage collection bug Nov 5, 2024
@jeongukjae jeongukjae changed the title Fix code coverage collection bug Combine all code coverages in CI Nov 5, 2024
@jeongukjae jeongukjae added type:task A general task type:skip-changelog A change that does not require a changelog entry and removed semver:patch A change requiring a patch version bump type:task A general task labels Nov 5, 2024
@jeongukjae jeongukjae marked this pull request as ready for review November 5, 2024 17:05
@sambhav sambhav merged commit 52670c4 into argoproj-labs:main Nov 5, 2024
27 of 33 checks passed
@jeongukjae jeongukjae deleted the test-codecov branch November 6, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:skip-changelog A change that does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants