Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add basic support for git tag path prefixes #20948

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

chzar
Copy link

@chzar chzar commented Nov 25, 2024

TL;DR This PR changes the resolveSemverRevision() to tolerate a path prefix before the semantic version.

# example
targetRevision: 'foo/bar/ >= v0.0.0-rc0'

This change is useful for teams that:

  • want to use hierarchical tags - useful for monorepos (app1/v0.0.0, app2/v1.0.0)
  • want to use a hierarchical namespace to route argo deployments using generators (app1/cluster1/prod/v0.0.0, app1/cluster2/dev/v0.0.0)
  • use git flow or other tag based workflows with path prefixes

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Copy link

bunnyshell bot commented Nov 25, 2024

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-lnnaku.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-lnnaku.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@chzar chzar changed the title feat: Add basic support for tag path prefixes feat: Add basic support for git tag path prefixes Nov 25, 2024
@chzar

This comment has been minimized.

@chzar chzar marked this pull request as ready for review November 25, 2024 21:29
@chzar chzar requested a review from a team as a code owner November 25, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant