fix: use cluster domain neutral svc dns #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-enso
force-pushed
the
master
branch
2 times, most recently
from
a0ecf1a
to
c7690de
Compare
igor-enso
changed the title
igor-enso
changed the title
igor-enso
changed the title
igor-enso
changed the title
igor-enso
force-pushed
the
master
branch
3 times, most recently
from
7f60eb1
to
b07cab3
Compare
|
@jmeridth can i merge this PR? (still not permitted, although approved) |
|
@igor-enso you and I do not have permissions. I'm going to add authorized folks as reviewers. I also created #2658 to hopefully alleviate this in the future. |
|
@jmeridth Thank you! |
igor-enso
force-pushed
the
master
branch
3 times, most recently
from
648f25a
to
62b9b04
Compare
whynowy
reviewed
Jun 19, 2023
Signed-off-by: Igor Makhtes <igor@enso.security>
whynowy
approved these changes
Jun 22, 2023
|
Best pr ever. |
whynowy
pushed a commit
that referenced
this pull request
Aug 31, 2023
Signed-off-by: Igor Makhtes <igor@enso.security>
|
Noticed a bug : #2824 Not sure completely if this is a expected behviour, however if i rollback this PR changes in my local, not seeing the bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2657
Current implementation of NATS eventbus assumes the cluster has 'cluster.local' domain defined, which not always the case.
Solution
Use cluster domain invariant service name -
evenbus-name.eventbus-namespace.svcinstead ofevenbus-name.eventbus-namespace.svc.cluster.localChecklist: