fix:eventsource crash on cast #3238 #3282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MenD32
pushed a commit
to MenD32/argo-events
that referenced
this pull request
Sep 23, 2024
Signed-off-by: MenD32 <amit@jounce.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Fixes #3238
This fix prevents argo-events from crashing when an unexpected, that is not a
*unstructured.Unstructured, is encountered. The solution is to filter out those objects as they cannot be parsed and will not have information that can be used in the rest of process.In the old situation argo-events would crash on receiving the unexpected object.
In the new situation argo-events will ignore the unexpected object.
In case that the object is indeed a
*unstructured.Unstructured, the program will behave as it did before.