Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:tracking evaluation #232

Closed
wants to merge 1 commit into from
Closed

fix:tracking evaluation #232

wants to merge 1 commit into from

Conversation

Redrew
Copy link
Contributor

@Redrew Redrew commented Oct 31, 2023

PR Summary

Currently tracking evaluation uses the class label id to match classes between prediction and ground truth tracks. This label id is defined based on the order of class names in the av2 repository. However, label ids could easily be misdefined in the predictions, eg. the LT3D repository uses label ids in a different order. This change uses the text array name instead of label id to match classes in evaluation.

Testing

In order to ensure this PR works as intended, it is:

  • unit tested.
  • other or not applicable (additional detail/rationale required)

Tested with example tracking predictions that uses a different label id ordering.

Compliance with Standards

As the author, I certify that this PR conforms to the following standards:

  • Code changes conform to PEP8 and docstrings conform to the Google Python style guide.
  • A well-written summary explains what was done and why it was done.
  • The PR is adequately tested and the testing details and links to external results are included.

@benjaminrwilson
Copy link
Collaborator

@Redrew , would you mind pulling main into this branch? I think it should fix some of the CI items pass.

@benjaminrwilson benjaminrwilson mentioned this pull request Dec 17, 2023
5 tasks
@benjaminrwilson
Copy link
Collaborator

Closed by #244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants