feat(anta.tests): New VXLAN tests #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmuloc
reviewed
Oct 17, 2023
anta/tests/vxlan.py
Outdated
Comment on lines
120
to
128
| vlan_ = vxlan1["vniBindings"][vni]["vlan"] | ||
| elif vni in vxlan1["vniBindingsToVrf"]: | ||
| vlan_ = vxlan1["vniBindingsToVrf"][vni]["vlan"] | ||
| else: | ||
| no_binding.append(vni) | ||
| vlan_ = None | ||
|
|
||
| if vlan_ and vlan != vlan_: | ||
| wrong_binding.append({vni: vlan_}) |
There was a problem hiding this comment.
change vlan_ with retrieved_vlan or something similar
There was a problem hiding this comment.
Fixed in 60aa011
anta/tests/vxlan.py
Outdated
Comment on lines
164
to
166
| if len(vteps := vxlan1["vteps"]) == 0: | ||
| self.result.is_failure("Vxlan1 interface has no VTEP") | ||
| return |
There was a problem hiding this comment.
what if input.vteps is an empty list ? Maybe someone wants to verify there is no VTEP peers :)
There was a problem hiding this comment.
Fixed in 60aa011
gmuloc
reviewed
Oct 17, 2023
tests/units/anta_tests/test_vxlan.py
Outdated
| @@ -303,7 +303,7 @@ | |||
| "test": VerifyVxlanVtep, | |||
| "eos_data": [{"vteps": {}, "interfaces": {"Vxlan1": {"vteps": ["10.1.1.5", "10.1.1.6"]}}}], | |||
| "inputs": {"vteps": []}, | |||
| "expected": {"result": "failure", "messages": ["Unexpected VTEP peer(s) on Vxlan1 interface: {'10.1.1.5', '10.1.1.6'}"]}, | |||
| "expected": {"result": "failure", "messages": ["Unexpected VTEP peer(s) on Vxlan1 interface: {'10.1.1.6', '10.1.1.5'}"]}, | |||
There was a problem hiding this comment.
Ah damn I am using sets that's why CI is failing sometimes...
gmuloc
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New VXLAN tests:
Checklist:
pre-commit run)tox -e testenv)