-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unsupported platform warning #437
Merged
gmuloc
merged 26 commits into
aristanetworks:main
from
mtache:feat/warning-unsupported-platform
Nov 24, 2023
Merged
feat: unsupported platform warning #437
gmuloc
merged 26 commits into
aristanetworks:main
from
mtache:feat/warning-unsupported-platform
Nov 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtache
requested review from
carl-baillargeon and
gmuloc
and removed request for
carl-baillargeon
October 25, 2023 17:17
mtache
changed the title
feat/warning unsupported platform
feat: unsupported platform warning
Oct 25, 2023
gmuloc
reviewed
Oct 27, 2023
mtache
force-pushed
the
feat/warning-unsupported-platform
branch
from
November 21, 2023 12:05
3e7e64f
to
8e2c661
Compare
gmuloc
reviewed
Nov 21, 2023
gmuloc
reviewed
Nov 21, 2023
gmuloc
reviewed
Nov 21, 2023
gmuloc
reviewed
Nov 21, 2023
mtache
force-pushed
the
feat/warning-unsupported-platform
branch
from
November 22, 2023 14:08
b14e921
to
552c60e
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
gmuloc
reviewed
Nov 23, 2023
gmuloc
reviewed
Nov 23, 2023
gmuloc
reviewed
Nov 23, 2023
gmuloc
reviewed
Nov 24, 2023
mtache
force-pushed
the
feat/warning-unsupported-platform
branch
from
November 24, 2023 09:52
4f147a2
to
ebb420d
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
gmuloc
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a command defined in a specific test returns the "not supported on this hardware platform" error, the test will be skipped (instead of being in error) and a clear warning will request the user to open a GitHub issue because the test needs to be skipped on specific hardware platform but this has not been implemented.
Example:
Changes:
Fixes #335
Fixes #421
Checklist:
pre-commit run
)tox -e testenv
)