feat(anta): Added the test case to verify the BGP route origin #813

vitthalmagadum · 2024-09-03T07:54:35Z

Description

Verifies BGP route origin for the provided IPv4 Network(s).

Expected Results
----------------
* Success: The test will pass if the BGP route's origin matches expected origin type.
* Failure: The test will fail if the BGP route's origin does not matches with expected origin type or BGP route entry(s) not found.

Fixes #811

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have run pre-commit for code linting and typing (pre-commit run)
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes (tox -e testenv)

anta/tests/routing/bgp.py

github-actions · 2024-09-17T15:59:15Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

…ut schema

github-actions · 2024-09-23T11:07:55Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

anta/tests/routing/bgp.py

examples/tests.yaml

…tsring

vitthalmagadum · 2024-09-25T06:20:26Z

Added pylint disable for no of line check (C0302) with TODO.
Thanks!!!

github-actions · 2024-09-27T06:19:07Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-09-27T08:43:32Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

anta/tests/routing/bgp.py

codspeed-hq · 2024-10-01T04:02:54Z

CodSpeed Performance Report

Merging #813 will not alter performance

_{Comparing vitthalmagadum:issue_811 (fbad6d7) with main (68c664d)}

Summary

✅ 22 untouched benchmarks

… path

sonarqubecloud · 2024-10-11T03:43:21Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-11-14T18:28:51Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-12-18T12:22:39Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

gmuloc · 2024-12-18T13:01:21Z

anta/tests/routing/bgp.py

+    """Verifies BGP route origin.
+
+    This test performs the following checks for each specified bgp route entry:
+      1. Checks whether the specified BGP route entries exist.


Suggested change

1. Checks whether the specified BGP route entries exist.

1. Checks whether the specified BGP route entry exists.

gmuloc · 2024-12-18T13:02:17Z

anta/tests/routing/bgp.py

+
+    This test performs the following checks for each specified bgp route entry:
+      1. Checks whether the specified BGP route entries exist.
+      2. Confirms that the path exists and corresponds to the next-hop address.


seems there can be multiple paths for a given route so what happens if I have multiple - do all need to exist ? only
one? this should be specified here

the code check that all paths for each route are valid

We are verifying the given path(s) should exist in entries for that given prefix.

yes so we need to reword

Suggested change

2. Confirms that the path exists and corresponds to the next-hop address.

2. Confirms that each path for the route entry exists and corresponds to the next-hop address.

Updated. Thanks!!

gmuloc · 2024-12-18T13:02:32Z

anta/tests/routing/bgp.py

+    ----------------
+    * Success: The test will pass if:
+        - The BGP route entries exist for specified prefixes.
+        - Path exists and corresponds to the specified next-hop address.


only one path?

@gmuloc
Yes we are verifying the path correspond to the given nexthop.

the point is that we have a list of paths so we shouuld reword that the success is only if every path exists. The sentence is currently singular

Suggested change

- Path exists and corresponds to the specified next-hop address.

- Every path exists and corresponds to the specified next-hop address.

check also if this is required for failure

Updated. Thanks!!

github-actions · 2024-12-24T15:59:54Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-12-30T16:36:57Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions · 2025-01-02T16:00:36Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2025-01-09T16:50:48Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

sonarqubecloud · 2025-01-09T16:52:37Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

issue_811 Added TC for BGP route origin

1f33640

github-actions bot assigned vitthalmagadum Sep 3, 2024

MaheshGSLAB reviewed Sep 17, 2024

View reviewed changes

anta/tests/routing/bgp.py Outdated Show resolved Hide resolved

anta/tests/routing/bgp.py Outdated Show resolved Hide resolved

github-actions bot added the state: conflict label Sep 17, 2024

VitthalMagadum added 2 commits September 23, 2024 06:55

Merge branch 'main' into issue_811

0e0a8d3

issue_811 Handling review comments: updated the variable name and inp…

4046dfb

…ut schema

vitthalmagadum force-pushed the issue_811 branch from 1aa5921 to 4046dfb Compare September 23, 2024 11:07

github-actions bot removed the state: conflict label Sep 23, 2024

vitthalmagadum requested a review from MaheshGSLAB September 23, 2024 11:08

MaheshGSLAB reviewed Sep 24, 2024

View reviewed changes

anta/tests/routing/bgp.py Outdated Show resolved Hide resolved

examples/tests.yaml Outdated Show resolved Hide resolved

issue_811 Handling review comments: updated the pylint ignore and doc…

1408772

…tsring

vitthalmagadum requested a review from MaheshGSLAB September 25, 2024 06:18

github-actions bot added the state: conflict label Sep 27, 2024

VitthalMagadum added 2 commits September 27, 2024 04:36

Merge branch 'main' into issue_811

3fb5245

issue_811 fix lintin issue

b9d1bea

vitthalmagadum force-pushed the issue_811 branch from 796aa99 to b9d1bea Compare September 27, 2024 08:43

github-actions bot removed the state: conflict label Sep 27, 2024

MaheshGSLAB reviewed Sep 30, 2024

View reviewed changes

anta/tests/routing/bgp.py Outdated Show resolved Hide resolved

issue_811 Handling review comments: updated vrf details in failure msg

07d115f

vitthalmagadum requested a review from MaheshGSLAB September 30, 2024 09:26

vitthalmagadum added 2 commits September 30, 2024 17:50

Merge branch 'main' into issue_811

2b615d7

Merge branch 'main' into issue_811

5c1a91a

MaheshGSLAB approved these changes Oct 4, 2024

View reviewed changes

Merge branch 'main' into issue_811

8a7fc6b

issue_811 Handling review comments: updated the input model for route…

15d5964

… path

vitthalmagadum requested a review from gmuloc October 11, 2024 03:40

github-actions bot added the state: conflict label Nov 14, 2024

vitthalmagadum added 2 commits December 18, 2024 02:14

Merge branch 'main' into issue_811

78c8ce9

Added input models refactoring

224b1e7

github-actions bot removed the state: conflict label Dec 18, 2024

vitthalmagadum requested review from MaheshGSLAB and carl-baillargeon December 18, 2024 12:37

vitthalmagadum marked this pull request as draft December 18, 2024 13:02

gmuloc requested changes Dec 18, 2024

View reviewed changes

vitthalmagadum force-pushed the issue_811 branch from b091e2a to 9b7c946 Compare December 19, 2024 12:01

Addressed review comment: updated doc, unit test eos data

b742646

vitthalmagadum force-pushed the issue_811 branch from 9b7c946 to b742646 Compare December 19, 2024 12:11

vitthalmagadum requested a review from gmuloc December 19, 2024 12:12

vitthalmagadum marked this pull request as ready for review December 19, 2024 12:12

github-actions bot added the state: conflict label Dec 24, 2024

vitthalmagadum added 2 commits December 30, 2024 11:32

Merge branch 'main' into issue_811

c399bd3

pre-commit changes after conflicts resolved

3981dd2

github-actions bot added state: conflict and removed state: conflict labels Dec 30, 2024

Merge branch 'main' into issue_811

fbad6d7

github-actions bot removed the state: conflict label Jan 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(anta): Added the test case to verify the BGP route origin #813

feat(anta): Added the test case to verify the BGP route origin #813

vitthalmagadum commented Sep 3, 2024

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 23, 2024

vitthalmagadum commented Sep 25, 2024

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 27, 2024

codspeed-hq bot commented Oct 1, 2024 •

edited

Loading

sonarqubecloud bot commented Oct 11, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Dec 18, 2024

gmuloc Dec 18, 2024

gmuloc Dec 18, 2024

gmuloc Dec 18, 2024

vitthalmagadum Dec 19, 2024

gmuloc Dec 19, 2024

vitthalmagadum Dec 19, 2024

gmuloc Dec 18, 2024

vitthalmagadum Dec 19, 2024

gmuloc Dec 19, 2024

gmuloc Dec 19, 2024

vitthalmagadum Dec 19, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 30, 2024

github-actions bot commented Jan 2, 2025

github-actions bot commented Jan 9, 2025

sonarqubecloud bot commented Jan 9, 2025

	1. Checks whether the specified BGP route entries exist.
	1. Checks whether the specified BGP route entry exists.

	2. Confirms that the path exists and corresponds to the next-hop address.
	2. Confirms that each path for the route entry exists and corresponds to the next-hop address.

	- Path exists and corresponds to the specified next-hop address.
	- Every path exists and corresponds to the specified next-hop address.

feat(anta): Added the test case to verify the BGP route origin #813

Are you sure you want to change the base?

feat(anta): Added the test case to verify the BGP route origin #813

Conversation

vitthalmagadum commented Sep 3, 2024

Description

Checklist:

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 23, 2024

vitthalmagadum commented Sep 25, 2024

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 27, 2024

codspeed-hq bot commented Oct 1, 2024 • edited Loading

Merging #813 will not alter performance

Summary

sonarqubecloud bot commented Oct 11, 2024

Quality Gate passed

github-actions bot commented Nov 14, 2024

github-actions bot commented Dec 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 30, 2024

github-actions bot commented Jan 2, 2025

github-actions bot commented Jan 9, 2025

sonarqubecloud bot commented Jan 9, 2025

Quality Gate passed

codspeed-hq bot commented Oct 1, 2024 •

edited

Loading