Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta): Added the test case to verify syslog logging is enabled #859

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Verifies if syslog logging is enabled.

Expected Results
----------------
* Success: The test will pass if syslog logging is enabled.
* Failure: The test will fail if syslog logging is disabled.

Fixes #855

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

codspeed-hq bot commented Oct 8, 2024

CodSpeed Performance Report

Merging #859 will not alter performance

Comparing vitthalmagadum:issue_855 (86a1047) with main (1f033f4)

Summary

✅ 22 untouched benchmarks

Copy link

sonarqubecloud bot commented Oct 11, 2024

Copy link
Contributor

github-actions bot commented Dec 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@carl-baillargeon carl-baillargeon merged commit 5389bb0 into aristanetworks:main Jan 14, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the test case to verify syslog logging is enabled on device.
4 participants