Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anta): Workaround to bypass resource on non-POSIX system #919

Merged
merged 30 commits into from
Dec 18, 2024

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Nov 7, 2024

Description

for now detecting when using non posix system and bypassing resource call

Fixes #917

TODO

  • Add windows runner in CI
  • Add test (faking system)
  • Find a solution to do the same check on Windows (if achievable)
    • no solution found
    • for now ignoring

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc changed the title Fix(anta): Workaroudn to bypass resource on none posix system fix(anta): Workaroudn to bypass resource on none posix system Nov 7, 2024
Copy link

codspeed-hq bot commented Nov 7, 2024

CodSpeed Performance Report

Merging #919 will not alter performance

Comparing gmuloc:issue/917 (cca04c3) with main (45a62d7)

Summary

✅ 22 untouched benchmarks

@carl-baillargeon carl-baillargeon changed the title fix(anta): Workaroudn to bypass resource on none posix system fix(anta): Workaround to bypass resource on none posix system Nov 7, 2024
@gmuloc
Copy link
Collaborator Author

gmuloc commented Nov 12, 2024

psutil was a deadend for windows rlimit: giampaolo/psutil#1149

@gmuloc gmuloc added this to the v1.2.0 milestone Nov 14, 2024
@gmuloc gmuloc marked this pull request as ready for review December 12, 2024 14:36
@gmuloc
Copy link
Collaborator Author

gmuloc commented Dec 12, 2024

probably should add something on this in the doc?

Copy link
Collaborator

@mtache mtache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows 11 Version 23H2 Build 22631.4541.

@gmuloc gmuloc changed the title fix(anta): Workaround to bypass resource on none posix system fix(anta): Workaround to bypass resource on non-POSIX system Dec 18, 2024
@gmuloc gmuloc merged commit 4f028f5 into aristanetworks:main Dec 18, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue for ANTA v1.1.0 on Windows
2 participants