Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(anta.tests): Update logging tests docstrings for clarity #923

Conversation

carl-baillargeon
Copy link
Contributor

Description

Update:

  • VerifyLoggingTimestamp
  • VerifyLoggingHostname
  • VerifyLoggingLogsGeneration

To specify that the tests will work only when EOS is configured with logging buffer secerity level info or higher.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

sonarqubecloud bot commented Nov 7, 2024

Copy link

codspeed-hq bot commented Nov 7, 2024

CodSpeed Performance Report

Merging #923 will not alter performance

Comparing carl-baillargeon:fix/veirfy_logging_timestamp_docstring (e82f52f) with main (634b1ec)

Summary

✅ 8 untouched benchmarks

@gmuloc gmuloc changed the title fix(anta.tests): Update logging tests docstrings for clarity doc(anta.tests): Update logging tests docstrings for clarity Nov 8, 2024
@gmuloc gmuloc merged commit 38992ef into aristanetworks:main Nov 8, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants