Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta.tests): Add known EOS errors as failure #959

Merged
merged 12 commits into from
Dec 17, 2024

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Dec 9, 2024

Description

Add a list of known errors from EOS to match on to decide a test status

Fixes #952
Fixes #954

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@carl-baillargeon
Copy link
Contributor

carl-baillargeon commented Dec 10, 2024

Routing tests are also giving an error if the routing protocol is not active (BGP, IS-IS):
DC2-BL2 :: VerifyEVPNType2Route :: ERROR(show bgp evpn route-type mac-ip aa:c1:ab:de:50:ad vni 10010 has failed: BGP inactive

@gmuloc
Copy link
Collaborator Author

gmuloc commented Dec 11, 2024

show bgp evpn route-type mac-ip aa:c1:ab:de:50:ad vni 10010

do you have an example for ISIS?

Copy link

codspeed-hq bot commented Dec 11, 2024

CodSpeed Performance Report

Merging #959 will not alter performance

Comparing gmuloc:issue/954 (293a190) with main (8f69f64)

Summary

✅ 8 untouched benchmarks

@gmuloc gmuloc marked this pull request as ready for review December 12, 2024 09:34
@gmuloc gmuloc added this to the v1.2.0 milestone Dec 12, 2024
anta/device.py Outdated Show resolved Hide resolved
anta/models.py Outdated Show resolved Hide resolved
@carl-baillargeon
Copy link
Contributor

show bgp evpn route-type mac-ip aa:c1:ab:de:50:ad vni 10010

do you have an example for ISIS?

@gmuloc:

{
    "vrfs": {
        "default": {
            "isisInstances": {}
        }
    },
    "errors": [
        "IS-IS (IS-IS) is disabled because: IS-IS address family configuration is not present"
    ]
}

It happens when you don't have address-family ipv4 | ipv6 configured

@gmuloc
Copy link
Collaborator Author

gmuloc commented Dec 12, 2024

Member

what is the command please? need to repro

@gmuloc gmuloc closed this Dec 12, 2024
@gmuloc gmuloc reopened this Dec 12, 2024
@gmuloc
Copy link
Collaborator Author

gmuloc commented Dec 12, 2024

ok found one :p

anta/models.py Outdated Show resolved Hide resolved
anta/device.py Outdated Show resolved Hide resolved
anta/models.py Outdated Show resolved Hide resolved
anta/models.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@carl-baillargeon carl-baillargeon merged commit c119777 into aristanetworks:main Dec 17, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: VerifyReachability Fix: VerifyIPProxyARP should not throw an error
2 participants