Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta.tests): Add test to verify mcs server mount states #961

Merged
merged 17 commits into from
Dec 16, 2024
Merged

feat(anta.tests): Add test to verify mcs server mount states #961

merged 17 commits into from
Dec 16, 2024

Conversation

sarunac
Copy link
Contributor

@sarunac sarunac commented Dec 10, 2024 •
edited by gmuloc
Loading

Description

Test to verify CVX MCS server mount states

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #961 will not alter performance

Comparing sarunac:mcsServerMounts (b5d962e) with main (9876833)

Summary

✅ 8 untouched benchmarks

@gmuloc gmuloc changed the title feat(anta): add tests to verify mcs server mount states feat(anta.tests): Add test to verify mcs server mount states Dec 10, 2024
gmuloc
gmuloc requested changes Dec 10, 2024
View reviewed changes
anta/tests/cvx.py Outdated Show resolved Hide resolved
anta/tests/cvx.py Outdated Show resolved Hide resolved
anta/tests/cvx.py Outdated Show resolved Hide resolved
anta/tests/cvx.py Outdated Show resolved Hide resolved
anta/tests/cvx.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_cvx.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_cvx.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_cvx.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_cvx.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_cvx.py Outdated Show resolved Hide resolved
sarunac and others added 2 commits December 10, 2024 07:38
@sarunac @gmuloc
Update anta/tests/cvx.py
3cb5218 
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@sarunac @gmuloc
Update anta/tests/cvx.py
aee0539 
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

gmuloc
gmuloc reviewed Dec 12, 2024
View reviewed changes
anta/tests/cvx.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@sarunac sarunac requested a review from gmuloc December 13, 2024 20:33
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gmuloc gmuloc merged commit 8f69f64 into aristanetworks:main Dec 16, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

Assignees

@sarunac sarunac

Labels
rn: feat(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarunac @gmuloc