Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta.tests): Cleaning up ISIS tests module #963

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(anta.tests): Cleaning up ISIS tests module #963

wants to merge 6 commits into from
+225 −231

Conversation

vitthalmagadum
Copy link
Collaborator

@vitthalmagadum vitthalmagadum commented Dec 10, 2024 •
edited
Loading

Description

Refactoring ISIS tests module to address the following issues:

Tests:

  • VerifyISISNeighborCount.Input.InterfaceCount
  • VerifyISISInterfaceMode.Input.InterfaceState
  • VerifyISISSegmentRoutingAdjacencySegments.Input.IsisInstance & Segment
  • VerifyISISSegmentRoutingDataplane.Input.IsisInstance
  • VerifyISISSegmentRoutingTunnels.Input.Entry & Vias

@vitthalmagadum vitthalmagadum marked this pull request as draft December 10, 2024 18:13
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #963 will not alter performance

Comparing vitthalmagadum:fix/isis_input (54f6742) with main (3b97984)

Summary

✅ 22 untouched benchmarks

@vitthalmagadum vitthalmagadum mentioned this pull request Dec 12, 2024
Open
32 tasks
@vitthalmagadum vitthalmagadum marked this pull request as ready for review December 12, 2024 05:06
carl-baillargeon
carl-baillargeon reviewed Dec 12, 2024
View reviewed changes
anta/input_models/routing/isis.py Outdated Show resolved Hide resolved
anta/input_models/routing/isis.py Outdated Show resolved Hide resolved
anta/input_models/routing/isis.py Outdated Show resolved Hide resolved
anta/input_models/routing/isis.py Outdated Show resolved Hide resolved
anta/input_models/routing/isis.py Outdated Show resolved Hide resolved
anta/input_models/routing/isis.py Outdated Show resolved Hide resolved
anta/input_models/routing/isis.py Outdated Show resolved Hide resolved
anta/tests/routing/isis.py Outdated Show resolved Hide resolved
tests/units/anta_tests/routing/test_isis.py Outdated Show resolved Hide resolved
@gmuloc
Copy link
Collaborator

gmuloc commented Dec 20, 2024

Please add coverage

Screenshot 2024-12-20 at 14 09 13

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon Awaiting requested review from carl-baillargeon

At least 1 approving review is required to merge this pull request.

Assignees

@vitthalmagadum vitthalmagadum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitthalmagadum @gmuloc @carl-baillargeon