fix(anta.tests): VerifySpecificPath testcase with the latest changes #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #965 will not alter performanceComparing Summary
|
32 tasks
vitthalmagadum
requested changes
Dec 26, 2024
anta/tests/path_selection.py
Outdated
| path_group_details = get_value(peer_details, f"dpsGroups..{path_group}..dpsPaths", separator="..") | ||
| # If the expected pathgroup is not found for the peer, the test fails. | ||
| if not path_group_details: | ||
| self.result.is_failure(f"{router_path} - Path-group not found") |
There was a problem hiding this comment.
Suggested change
| self.result.is_failure(f"{router_path} - Path-group not found") | |
| self.result.is_failure(f"{router_path} - DPS paths not found") |
anta/tests/path_selection.py
Outdated
| path_data = next((path for path in path_group_details.values() if (path.get("source") == source and path.get("destination") == destination)), None) | ||
| # If the expected and actual source and destion address of the pathgroup are not matched, test fails. | ||
| if not path_data: | ||
| self.result.is_failure(f"{router_path} - Source and/or Destination address not found") |
There was a problem hiding this comment.
Suggested change
| self.result.is_failure(f"{router_path} - Source and/or Destination address not found") | |
| self.result.is_failure(f"{router_path} - path not found") |
anta/tests/path_selection.py
Outdated
| if path_state not in ["ipsecEstablished", "routeResolved"]: | ||
| self.result.is_failure(f"Path state for `peer: {peer} source: {source} destination: {destination}` in path-group {path_group} is `{path_state}`.") | ||
| if path_state not in expected_state: | ||
| self.result.is_failure(f"{router_path} - Incorrect path state - Expected: {' or '.join(expected_state)} Actual: {path_state}") |
There was a problem hiding this comment.
We can use comma(,) to join. Please ensure the CSV report once.
anta/tests/path_selection.py
Outdated
| self.result.is_failure( | ||
| f"Telemetry state for path `peer: {peer} source: {source} destination: {destination}` in path-group {path_group} is `inactive`." | ||
| ) | ||
| self.result.is_failure(f"{router_path} - Incorrect telemetry state - Expected: active Actual: inactive") |
There was a problem hiding this comment.
Suggested change
| self.result.is_failure(f"{router_path} - Incorrect telemetry state - Expected: active Actual: inactive") | |
| self.result.is_failure(f"{router_path} - Telemetry state inactive") |
anta/tests/path_selection.py
Outdated
| @@ -70,16 +68,21 @@ def test(self) -> None: | |||
|
|
|||
|
|
|||
| class VerifySpecificPath(AntaTest): | |||
| """Verifies the path and telemetry state of a specific path for an IPv4 peer under router path-selection. | |||
| """Verifies the path and telemetry state of a specific path for an IPv4 peer. | |||
There was a problem hiding this comment.
Suggested change
| """Verifies the path and telemetry state of a specific path for an IPv4 peer. | |
| """Verifies the DPS path and telemetry state of an IPv4 peer. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring PathSelection (VerifySpecificPath) tests module to address the following issues:
Checklist:
pre-commit run)tox -e testenv)