Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstring and typing to estimation #611

Merged
merged 37 commits into from
Nov 16, 2023

Conversation

Sichao25
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1e8ffe4) 22.54% compared to head (8d09107) 22.15%.
Report is 71 commits behind head on master.

Files Patch % Lines
dynamo/estimation/tsc/estimation_kinetic.py 98.95% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
- Coverage   22.54%   22.15%   -0.39%     
==========================================
  Files         166      166              
  Lines       27362    27988     +626     
==========================================
+ Hits         6168     6200      +32     
- Misses      21194    21788     +594     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sichao25 Sichao25 marked this pull request as ready for review November 15, 2023 22:37
@Xiaojieqiu Xiaojieqiu merged commit 773a43c into aristoteleo:master Nov 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants