This repository has been archived by the owner on May 30, 2023. It is now read-only.
Fix for PDF text not being selectable on Mac OSX #11723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Produces selectable text when printing/rasterizing to PDF on OSX. ariya#10373
|
|
||
| // Fix for PDF prints on Mac OSX. Produces selectable text | ||
| #ifdef Q_WS_MACX | ||
| if(fileName.endsWith(".pdf")) { |
There was a problem hiding this comment.
If you're in this method, then you will be rendering a PDF. Just force the output format if the platform is OS X. Don't check the filename extension.
There was a problem hiding this comment.
Ya, that makes a lot of sense. I will change it and add a commit soon.
|
I removed the check for filename extension as @sodabrew recommended. |
|
My take is still the same (as in #11509): until someone can do an in-depth analysis of the impact w.r.t. what Qt produces with this patch, it's too risky to land the patch. Meanwhile, I'll place this under |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Produces selectable text when printing/rasterizing to PDF on OSX.
#10373
Please note: this PR is almost the same as the original one by FreshXOpenSource: #11509 - the difference is that I have tried to refactor the PR to meet Contribution Guidelines and removed the filename extension check.