Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Repeat thead and tfoot when table contains page breaks #13331

Closed
wants to merge 5 commits into from
Closed

Repeat thead and tfoot when table contains page breaks #13331

wants to merge 5 commits into from

Commits on Jun 16, 2015

  1. Repeat thead and tfoot when table contains page breaks 

    This has been done a few times before[0][1], but seems to be broken
again as reported in [2].

This commit is only reinstating what's missing from [1]. This was done
by running:

    git log -p -1 2d778f6 | git apply -3 -p6 --directory=src/qt/qtwebkit

And resolving the conflicts. There are still some compile errors. These
will be fixed in the upcoming commits instead of in this one to clarify
the changes.

[0]: ariya#211
[1]: ariya#344
[2]: ariya#13324
    @trygveaa
    trygveaa committed Jun 16, 2015
    Configuration menu
    Copy the full SHA
    218a937 View commit details
    Browse the repository at this point in the history

  2. Remove missing ParentToChildFlippingAdjustment argument 

    Remove the ParentToChildFlippingAdjustment argument from
flipForWritingMode. This variable doesn't exist anymore. Instead, call
flipForWritingModeForChild instead of flipForWritingMode. This seems to
be what's done in the current code.

This fixes some errors after 218a937.
    @trygveaa
    trygveaa committed Jun 16, 2015
    Configuration menu
    Copy the full SHA
    b6c6ee4 View commit details
    Browse the repository at this point in the history

  3. Replace tx/ty with paintOffset 

    This fixes some errors after 218a937. tx/ty seems to have been replaced
by paintOffset other places. This replaces it in the code from 218a937
as well.
    @trygveaa
    trygveaa committed Jun 16, 2015
    Configuration menu
    Copy the full SHA
    cf33105 View commit details
    Browse the repository at this point in the history

  4. Fix return types from flipForWritingModeForChild 

    flipForWritingModeForChild returns a LayoutPoint. This changes the types
of some variables from IntPoint to LayoutPoint.

This fixes some errors after 218a937.
    @trygveaa
    trygveaa committed Jun 16, 2015
    Configuration menu
    Copy the full SHA
    2ce20e0 View commit details
    Browse the repository at this point in the history

  5. Give a IntPoint to paint instead of x and y 

    This fixes the last errors after 218a937.

I have confirmed that both the thead and the tfoot blocks are repeated
on the next pages when a table breaks over multiple pages. The other
content was already moved to take account of the size of thead and
tfoot, so this change doesn't affect any other content.

This fixes issue ariya#13324.
ariya#13324
    @trygveaa
    trygveaa committed Jun 16, 2015
    Configuration menu
    Copy the full SHA
    16fcb30 View commit details
    Browse the repository at this point in the history